Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix files table to only remove row from state after mutation succeeds #20881

Open
mddilley opened this issue Feb 1, 2025 · 0 comments
Open
Labels
Need: 2-Should Have May be painful to leave out, but the solution is still viable Product: Moped A comprehensive mobility project tracking platform for Austin, Texas Service: Dev Infrastructure and engineering Workgroup: TPW Transportation & Public Works Department

Comments

@mddilley
Copy link

mddilley commented Feb 1, 2025

When deleting a row from the files table, Rose caught that the state update is happening before the delete mutation succeeds. See cityofaustin/atd-moped#1521 (comment)

To reproduce:

  1. Go to a project's files table with files (like project 290 in a production snapshot) or add some files
  2. Use your browser dev tools to set your connection to "Offline"
  3. Delete a file and see that an error snackbar appears but the row has already deleted from the table state even though the mutation failed
@mddilley mddilley added Need: 2-Should Have May be painful to leave out, but the solution is still viable Product: Moped A comprehensive mobility project tracking platform for Austin, Texas Service: Dev Infrastructure and engineering Workgroup: TPW Transportation & Public Works Department labels Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Need: 2-Should Have May be painful to leave out, but the solution is still viable Product: Moped A comprehensive mobility project tracking platform for Austin, Texas Service: Dev Infrastructure and engineering Workgroup: TPW Transportation & Public Works Department
Projects
None yet
Development

No branches or pull requests

1 participant