Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTPS Protocol is NOT supported #11

Closed
ye opened this issue Mar 30, 2016 · 4 comments
Closed

HTTPS Protocol is NOT supported #11

ye opened this issue Mar 30, 2016 · 4 comments

Comments

@ye
Copy link
Contributor

ye commented Mar 30, 2016

It looks like rave-lua doesn't support HTTPS yet as of March 2016 as seen in raven.lua. Unfortunately, this is a deal-breaker for a lot of folks out there because the hosted version of Sentry only supports HTTPS!
@mattrobenolt
Copy link
Contributor

See: #4 but I was also told this approach isn't very secure and/or good. I'm not a Lua person, but was just hacking around on this a while back, so not sure the correct approach.

@ye
Copy link
Contributor Author

ye commented Apr 7, 2016

@mattrobenolt why wasn't it very secure / good? What's the hold back? That PR was more than 1 year old!

@mattrobenolt
Copy link
Contributor

I don't know, someone who knew more Lua than me said it was bad. That's all I remember.

@jdesgats
Copy link
Contributor

Solved by #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ye @mattrobenolt @jdesgats