Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] root docker-compose.yaml needs to be updated #74

Open
ToddG opened this issue Dec 31, 2020 · 0 comments
Open

[BUG] root docker-compose.yaml needs to be updated #74

ToddG opened this issue Dec 31, 2020 · 0 comments
Assignees

Comments

@ToddG
Copy link

ToddG commented Dec 31, 2020

REPRO

cd build
./build.sh

spark-standalone-cluster-on-docker/build $ diff docker-compose.yml ../docker-compose.yml 
12c12
<     image: jupyterlab:3.0.0-spark-3.0.0
---
>     image: andreper/jupyterlab:3.0.0-spark-3.0.0
20c20
<     image: spark-master:3.0.0
---
>     image: andreper/spark-master:3.0.0
28c28
<     image: spark-worker:3.0.0
---
>     image: andreper/spark-worker:3.0.0
40c40
<     image: spark-worker:3.0.0
---
>     image: andreper/spark-worker:3.0.0
  1. The root yaml needs to be updated as part of the build process?
  2. mispelled maintainer in Dockerfiles
$ grep manteiner * -R
docker/base/Dockerfile:LABEL manteiner="Andre Perez <[email protected]>"
docker/spark-base/Dockerfile:LABEL manteiner="Andre Perez <[email protected]>"
docker/jupyterlab/Dockerfile:LABEL manteiner="Andre Perez <[email protected]>"
docker/spark-worker/Dockerfile:LABEL manteiner="Andre Perez <[email protected]>"
docker/spark-master/Dockerfile:LABEL manteiner="Andre Perez <[email protected]>"
  1. Not sure why you overwriting maintainer lable in child Dockerfiles. IIRC they are inherited, and so only need defining in base image.
@ToddG ToddG changed the title [BUG] root docker-compose.yaml needs to be updated, does not batch what get's built in ./build [BUG] root docker-compose.yaml needs to be updated, does not match what get's built in ./build Dec 31, 2020
@ToddG ToddG changed the title [BUG] root docker-compose.yaml needs to be updated, does not match what get's built in ./build [BUG] root docker-compose.yaml needs to be updated Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants