Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A lot of marionette damage is either missing or awarded to the wrong player #23

Closed
coavins opened this issue Feb 4, 2022 · 2 comments
Closed
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@coavins
Copy link
Owner

coavins commented Feb 4, 2022

Describe the bug
When a player is mounting a monster with the wirebug, the damage dealt by that monster seems to be credited to player 1 internally by the game. There are also some moves that are not tracked through the existing hook at all.

Steps to Reproduce
For example:

  1. Use default settings
  2. Enter quest with multiple players
  3. Mount monster as someone other than player 1
  4. See player 1 accumulate damage dealt by the monster

Expected behavior
Damage dealt by mounted monsters should be awarded either to the monster or to the player who is riding them, preferably with an option to choose which one.

Additional context
This will involve digging through a lot of the objects to find out where it keeps track of which player is riding which monster so we can identify when the attacker ID on marionette damage should be overridden.

We should also figure out exactly what damage is missed and how to track it.

@coavins coavins added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed labels Feb 4, 2022
@coavins
Copy link
Owner Author

coavins commented Feb 13, 2022

Version 2.6.0 partially addresses this. An issue was fixed where player 1 would be sometimes credited with damage from monsters. This was because some monsters internally share the same "unique ID" with the first player. I fixed this by assigning these monsters new IDs in the monster cache.

Some monster damage is still missed, such as "launch" damage and some finishing moves.

@coavins
Copy link
Owner Author

coavins commented Jun 30, 2022

Closing this issue since the main problem was resolved. Remaining work was captured in #31

@coavins coavins closed this as completed Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant