-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log message when invalidating record using "isEmpty" #209
Comments
You're right, this would be useful. Any suggestion about error level? Warning? Notice? |
Anything which is accessible at least from the log module should be fine. A cherry on the top would be a single warning in the module/CLI if there was at least one skipped record . |
The patch introduces logging using External Import's debug mechanism (at "error" level). So you need to activate the debug mode and set a proper logger configuration (for the Last time I looked, entries written with TYPO3's logging system to the I'm not marking this issue as resolved, as I think that the cherry on top you mention is a worthwhile idea, but I would like to rework the messaging mechanism (also in relation to #179). |
The
isEmpty
transformation introduced with version 6.0 allows for dropping whole records in case a field is empty.This is very useful but for debugging purposes and for giving feedback to the data source provider a message should be logged on every record which is dropped this way. This way it is rather easy to find the affected source records and fix them.
Right now we do this with a custom step which triggers a warning message in case a record is dropped. The record is added to the message as JSON encoded string.
The text was updated successfully, but these errors were encountered: