Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bars jump when percentages are the label #15594

Closed
garrett opened this issue Mar 25, 2021 · 1 comment
Closed

Progress bars jump when percentages are the label #15594

garrett opened this issue Mar 25, 2021 · 1 comment
Labels
good-first-issue Appropriate for new contributors page:updates Software Updates

Comments

@garrett
Copy link
Member

garrett commented Mar 25, 2021

On at least the software page, possibly on other places, the progressbar width shifts as the numbers increment.

The proper solution would be to use tabular numbers, but our font does not support that (yet). Related: #15090 & RedHatOfficial/RedHatFont#27

Therefore, a work-around that we could do right now is to set min-width: 3ch on the label. As this would affect anything with a progress bar, we should probably have this as an override.

@KKoukiou KKoukiou added the page:updates Software Updates label Mar 25, 2021
@martinpitt martinpitt added the good-first-issue Appropriate for new contributors label Jul 29, 2021
@jelly
Copy link
Member

jelly commented Aug 5, 2021

For the "Software Updates" case I reproduced the issue using the testUpdates.testBasic test case and extending it with:

+        for i in range(1, 35):
+            pkgname = "test{}".format(i)
+            self.createPackage(pkgname, "1.0", "1", install=True)
+            self.createPackage(pkgname, "1.0", "2", postinst="sleep 1;")
         # create two updates; force installing chocolate before vanilla

This makes the issue visible for me.

I also noticed the issue with the CPU/Memory graphs on the Overview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Appropriate for new contributors page:updates Software Updates
Projects
None yet
Development

No branches or pull requests

4 participants