Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell: Slim version for "fullscreen" mode (for VNC and third party apps) #18433

Open
garrett opened this issue Mar 1, 2023 · 2 comments
Open

Comments

@garrett
Copy link
Member

garrett commented Mar 1, 2023

Related to

We should have a slimmer version of the shell, where an app can request a smaller version. This would be useful for detail pages that need more screen space, such as the VNC viewer in apps.

Screenshot of mockup @ https://garrett.github.io/cockpit-mockweb/navigation2/fullscreen.html:

image

@kartikvirendrar
Copy link

Hello @garrett, I would like to work on this issue can I get some more details

@garrett
Copy link
Member Author

garrett commented Mar 6, 2023

@kartikvirendrar: Nice!

All the design details are already included here.

I don't know what it would take, except that it would require the shell to have this smaller version and there would need to be some API from the page inside the iframe to communicate to the shell so that the shell would switch modes.

The mode would:

  1. hide the navigation on the side
  2. add a back link at the top

You'll have to talk to someone else via IRC (during standard European hours) about how the shell works. @martinpitt and @jelly are probably both good people to ask about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants