-
-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove our text <input></input> limits (Max playback speed or max volume need not be limited) #2028
Comments
Hi, i want to fix it if it doesn't been fixed |
hi! @klimchd beyond 2.77 doesnt sound healthy! / dont want to feel involved with that. |
@ImprovedTube I was using 3+x for years and everything fine, no worries! :) Currently the input field also limited by 2.75 (auto corrects to this value). I would be happy to use only the input, no need to extend the slider. |
Hi, i want to fix it if it doesn't been fixed |
tbh default max is 2.75 but u can easly expand that with shortcuts! |
@Anoaxx Thanks for the tip! I can at least use the shortcuts for now. But it works only for current video, it's nice to have the default speed for any video. |
so it overwrote your current setting? @klimchd can be max. 3.5 for now, just for you :D
my bad, thinking you can enter any number. |
@ImprovedTube I will be happy if the input would accept any number, thank you! Also fixed it for now in my local copy of the extension. Of course it will be overwritten with the next update. |
bump! hi, @klimchd (sorry for the further delay.)
|
Thanks for the reply! I notice another issue with speed not applied properly: the speed setting of the extension is not applied and video plays with YouTube default (i.e. 2.0x). It occurs randomly and usually fixed with page reload (sometimes it takes several times). The hotkeys also change speed only up to 2.0. It feels like some part of the script is not loaded/executed. |
hi!! @klimchd
how often? please check maybe sometimes only youtube's settings are available and the universal way to set speed for the HTMLMediaElement fails? also
so it is rare but sticky? youtube might remembers the speed per video? (when set manually?) Our function tries to respects that assuming, that any speed that is already there was set manually. |
@ImprovedTube When issue appears, pressing the speedup hotkey will result in "2x" at the top-center Tried to reproduce it:
|
thanks!
which wasn't true and played at your 3x?
can remember more?
👍 (btw🤫Not all browsers have the limit of 16x) |
Looks like the reload fixes it every time.
No, it seems to be playing at 2x. But I can change it by slider in the extension popup to 3x and then the hotkeys value 2x is invalid.
No, sorry. I think speed up was broken completely (probably even sereral times) and after the fix it started working somewhat unreliably. But I really can't remember the timeline. It's the same issue with hotkeys not working as #2166 I notice two issues with default hotkeys:
Tested Chrome, Opera and Edge the limit is 16 on these. |
hi! @klimchd, thanks frequency of the bug will be good to know still. hopefully it will can be fixed when we re-evaluated the timing of some of our functions.
QWERTY
firefox is unlimited😅 |
What happened to the max speed? I swear it used to do 4x, maybe even faster. Now it's limited to only 3.17x? |
About a month ago I switched to another extension purely for speed control. It has one huge benefit - works on every video, not only Youtube. |
Bug Report:
⚬ BUG: Max playback speed is limited by 2.75. I'm using 3-3.5x, would be good to restore the limit to the previous 4x
⚬ HOW: Settings -> Player -> Playback speed (the max value of the slider is 2.75)
⚬ Fix: Should be fixable just by changing the value "2.77" back to 4 here
The text was updated successfully, but these errors were encountered: