Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(50% 75%) [100%] 150% (200%) subtitle font size #2258

Closed
ImprovedTube opened this issue May 10, 2024 · 5 comments
Closed

(50% 75%) [100%] 150% (200%) subtitle font size #2258

ImprovedTube opened this issue May 10, 2024 · 5 comments
Labels
Completion to revise (rethink, improve, tweak) (this feature or structure) good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@ImprovedTube
Copy link
Member

ImprovedTube commented May 10, 2024

must be some of the edits of satus.js or menu/skeleton

@ImprovedTube ImprovedTube added Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels May 10, 2024
@ImprovedTube ImprovedTube added Structures (UX & ORG & Teamwork) Let's focus on structure! Everything should be as easily seen/found as it is relevant. Completion to revise (rethink, improve, tweak) (this feature or structure) and removed Bug Bug or required update after YouTube changes labels May 10, 2024
@ImprovedTube ImprovedTube changed the title subtitle font size: 50% by default ultimate GUI element May 10, 2024
@ImprovedTube ImprovedTube added the Feature request Wish or idea label May 10, 2024
@ImprovedTube ImprovedTube changed the title ultimate GUI element subtitle font size: 50% by default May 10, 2024
@ImprovedTube ImprovedTube removed Structures (UX & ORG & Teamwork) Let's focus on structure! Everything should be as easily seen/found as it is relevant. Completion to revise (rethink, improve, tweak) (this feature or structure) labels May 10, 2024
@ImprovedTube
Copy link
Member Author

(might be good to review, even if it needs not to be fixed? @raszpl)

@raszpl
Copy link
Contributor

raszpl commented May 10, 2024

Thats because I havent finished #2220
in my private built it all works fine :]

please revert 68d362d, instead add value: -2

ImprovedTube added a commit that referenced this issue May 10, 2024
@ImprovedTube
Copy link
Member Author

( final only for today. )

@raszpl
Copy link
Contributor

raszpl commented May 11, 2024

331bb1c equally bad :) fixed in #2262

edit: That was not fair just calling it bad, Im sorry :( What I meant was swapping options around doesnt reflect YT option order

While I was there I also consolidated all subtitle font options into one seeing they all did same thing #2263

@ImprovedTube ImprovedTube added Completion to revise (rethink, improve, tweak) (this feature or structure) and removed Feature request Wish or idea labels May 12, 2024
@ImprovedTube ImprovedTube changed the title subtitle font size: 50% by default (50% 75%) [100%] 150% (200%) subtitle font size May 12, 2024
@ImprovedTube
Copy link
Member Author

ImprovedTube commented May 12, 2024

Yes, while showing 50% by default wasn't consistent with our other drop-down,
ordered by size and pre-selecting/marking 100% as an index will be closer to Youtube's version (And one could make the lower values appear on top of the dropdown too even). (Besides that taking ~5 clicks people might just use it once set&forget - or rarely (unlike #1445 etc.) (And another order would be the [assumed] frequency of usage in our extension. )

And every number can come with a slider, allowing 50%-300% maybe. (And an input with no limits, or a bit wider range like 20-800)

  • Every number could also come with 1. a slider and 2. a toggle to default to the average or a drop-down if there are multiple peaks in the range. (3. the input - All three things in one button or row.) (and a slider can have a finer range, near the peak/s. automatically so if we collect settings data.) [<----------[▿85%▵]-->]▼

#2260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completion to revise (rethink, improve, tweak) (this feature or structure) good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

No branches or pull requests

2 participants