Can't take screenshots with shortcut after a min

[mina0728]

Bug Report:

• **Description:Can't take screenshots with shortcut after a min

• **Steps to reproduce this: It's fine initially after entering/refreshing the page for like a min or two, but it won't take screenshots with keyboard shortcut after that (the button shortcut is always good)

• **Since when?: A couple days ago, probably 2 or 3 days?

• **Browser:firefox 127.0.2

• **Are any errors shown in the Browser-Console?:F12 does show this , but I'm not sure.

Reason: CORS request not HTTP
https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS/Errors/CORSRequestNotHttp

• **Does the bug not happen when you log out of YouTube? : I tried in incognito mode and the problem still exists.

[ImprovedTube]

hi! and thanks @mina0728
since version 4.1007? - check 4.1070

[mina0728]

hi! and thanks @mina0728 since version 4.1007? - check 4.1070

I just downgraded it to 4.937(there's no 4.1070 in addon store), and it works smoothly now! So it must be the issue with 4.1007.

[raszpl]

I think the bug is this #2166

https://github.com/code-charity/youtube/releases/tag/v4.1070 says it includes #2421 but also says it was "released this 3 weeks ago"? whats going on ? :)
There is no 4.1007 tag to compare differences directly.

[mina0728]

Update: It also stop working in 4.937. Guess the initial delusion caught me.

[raszpl]

I think it was broken for a veeeery long time, people were just getting lucky or quickly assuming YT/browser went nuts and reloading. I just hope my fix didnt make it worse :)

[mina0728]

Correction : Turns out 4.937 is perfectly fine, it was auto-updated to 4.1007 without my knowledge yesterday lol,

I've turn update off.

[raszpl]

Thats weird, 1007 predates my major patch to shortcuts.js :|
The only changes are to actual ImprovedTube.screenshot() itself, and if it works with a button it should work with shortcut