Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Embedded area size is static and often much larger than the content #2

Open
Himura2la opened this issue Oct 31, 2017 · 1 comment

Comments

@Himura2la
Copy link
Contributor

It was discussed in #1

The best option is to determine the size of contents and clip the board automatically

As a quick fix, you can just let the user control the width/height values via the GET parameters

Example: http://img.catbo.at/oembed.json?url=http://img.catbo.at/3fb93c1b7891aedb18aa41fb325cbc92e82e58a1.jpg&maxwidth=200&maxheight=45&format=json

@codeOfRobin
Copy link
Owner

The quick fix definitely sounds reasonable. Would you like to implement it? It should be simple enough, simply change

embedJSON["width"] = 400
to a query prameter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants