From 44589296fec1d01f716a36142db126654551c9c4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20Mei=C3=9Fner?= Date: Thu, 12 Nov 2020 14:43:20 +0100 Subject: [PATCH] fix #25 - add validate_certs parameter add validate_certs parameter add validate_certs param to section test prepare release --- CHANGELOG.rst | 8 ++++++++ changelogs/changelog.yaml | 7 +++++++ docs/plugins/address_module.rst | 19 +++++++++++++++++ docs/plugins/device_module.rst | 19 +++++++++++++++++ docs/plugins/device_type_module.rst | 19 +++++++++++++++++ docs/plugins/domain_module.rst | 19 +++++++++++++++++ docs/plugins/index.rst | 1 + docs/plugins/nameserver_module.rst | 19 +++++++++++++++++ docs/plugins/section_module.rst | 19 +++++++++++++++++ docs/plugins/subnet_module.rst | 19 +++++++++++++++++ docs/plugins/tag_module.rst | 28 ++++++++++++++++++++++++++ docs/plugins/vlan_module.rst | 19 +++++++++++++++++ docs/plugins/vrf_module.rst | 19 +++++++++++++++++ galaxy.yml | 2 +- plugins/doc_fragments/phpipam.py | 5 +++++ plugins/module_utils/phpipam_helper.py | 1 + tests/test_playbooks/tasks/section.yml | 1 + 17 files changed, 223 insertions(+), 1 deletion(-) create mode 100644 docs/plugins/tag_module.rst diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 53714ea..557569a 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -5,6 +5,14 @@ codeaffen.phpipam Release Notes .. contents:: Topics +v1.1.0 +====== + +Bugfixes +-------- + +- Fixing `There is no `validate_certs` parameter in modules` bug (https://github.com/codeaffen/phpipam-ansible-modules/issues/25) + v1.0.0 ====== diff --git a/changelogs/changelog.yaml b/changelogs/changelog.yaml index df90a30..9526604 100644 --- a/changelogs/changelog.yaml +++ b/changelogs/changelog.yaml @@ -44,3 +44,10 @@ releases: fragments: - finally_go_stabel.yml release_date: '2020-10-30' + 1.1.0: + changes: + bugfixes: + - Fixing `There is no `validate_certs` parameter in modules` bug (https://github.com/codeaffen/phpipam-ansible-modules/issues/25) + fragments: + - missing_validate_certs_parameter.yml + release_date: '2020-11-12' diff --git a/docs/plugins/address_module.rst b/docs/plugins/address_module.rst index 316bdb9..b3f6ed4 100644 --- a/docs/plugins/address_module.rst +++ b/docs/plugins/address_module.rst @@ -374,6 +374,25 @@ Parameters
Username to access phpIPAM server
+ + + +
+ validate_certs + +
+ boolean +
+ + + + + +
Is the TLS certificate of the phpIPAM server verified or not.
+
diff --git a/docs/plugins/device_module.rst b/docs/plugins/device_module.rst index 4e1e86c..814a636 100644 --- a/docs/plugins/device_module.rst +++ b/docs/plugins/device_module.rst @@ -456,6 +456,25 @@ Parameters
Username to access phpIPAM server
+ + + +
+ validate_certs + +
+ boolean +
+ + + + + +
Is the TLS certificate of the phpIPAM server verified or not.
+
diff --git a/docs/plugins/device_type_module.rst b/docs/plugins/device_type_module.rst index e3ca15b..78db881 100644 --- a/docs/plugins/device_type_module.rst +++ b/docs/plugins/device_type_module.rst @@ -180,6 +180,25 @@ Parameters
Username to access phpIPAM server
+ + + +
+ validate_certs + +
+ boolean +
+ + + + + +
Is the TLS certificate of the phpIPAM server verified or not.
+
diff --git a/docs/plugins/domain_module.rst b/docs/plugins/domain_module.rst index b3b8605..09996fd 100644 --- a/docs/plugins/domain_module.rst +++ b/docs/plugins/domain_module.rst @@ -195,6 +195,25 @@ Parameters
Username to access phpIPAM server
+ + + +
+ validate_certs + +
+ boolean +
+ + + + + +
Is the TLS certificate of the phpIPAM server verified or not.
+
diff --git a/docs/plugins/index.rst b/docs/plugins/index.rst index 192b497..b144ed7 100644 --- a/docs/plugins/index.rst +++ b/docs/plugins/index.rst @@ -21,6 +21,7 @@ Module Plugins * :ref:`nameserver ` -- Manage nameservers * :ref:`section ` -- Manage sections * :ref:`subnet ` -- Manage subnets +* :ref:`tag ` -- * :ref:`vlan ` -- Manage vlans * :ref:`vrf ` -- Manage virtual routers and forwarders diff --git a/docs/plugins/nameserver_module.rst b/docs/plugins/nameserver_module.rst index 7f10dd2..2b63b3c 100644 --- a/docs/plugins/nameserver_module.rst +++ b/docs/plugins/nameserver_module.rst @@ -210,6 +210,25 @@ Parameters
Username to access phpIPAM server
+ + + +
+ validate_certs + +
+ boolean +
+ + +
    Choices: +
  • no
    • +
  • yes ←
    • +
+ + +
Is the TLS certificate of the phpIPAM server verified or not.
+
diff --git a/docs/plugins/section_module.rst b/docs/plugins/section_module.rst index 7a5caaa..76c368c 100644 --- a/docs/plugins/section_module.rst +++ b/docs/plugins/section_module.rst @@ -336,6 +336,25 @@ Parameters
Username to access phpIPAM server
+ + + +
+ validate_certs + +
+ boolean +
+ + +
    Choices: +
  • no
    • +
  • yes ←
    • +
+ + +
Is the TLS certificate of the phpIPAM server verified or not.
+
diff --git a/docs/plugins/subnet_module.rst b/docs/plugins/subnet_module.rst index eb63652..5d7a960 100644 --- a/docs/plugins/subnet_module.rst +++ b/docs/plugins/subnet_module.rst @@ -505,6 +505,25 @@ Parameters
Username to access phpIPAM server
+ + + +
+ validate_certs + +
+ boolean +
+ + +
    Choices: +
  • no
    • +
  • yes ←
    • +
+ + +
Is the TLS certificate of the phpIPAM server verified or not.
+ diff --git a/docs/plugins/tag_module.rst b/docs/plugins/tag_module.rst new file mode 100644 index 0000000..ee42518 --- /dev/null +++ b/docs/plugins/tag_module.rst @@ -0,0 +1,28 @@ +.. Document meta section + +:orphan: + +.. Document body + +.. Anchors + +.. _ansible_collections.codeaffen.phpipam.tag_module: + +.. Title + +codeaffen.phpipam.tag ++++++++++++++++++++++ + + +The documentation for the module plugin, codeaffen.phpipam.tag, was malformed. + +The errors were: + +* :: + + 1 validation error for ModuleDocSchema + doc -> options -> fgcolor -> rquired + extra fields not permitted (type=value_error.extra) + + +File a bug with the `codeaffen.phpipam collection `_ in order to have it corrected. \ No newline at end of file diff --git a/docs/plugins/vlan_module.rst b/docs/plugins/vlan_module.rst index 8d12a89..758f4ad 100644 --- a/docs/plugins/vlan_module.rst +++ b/docs/plugins/vlan_module.rst @@ -195,6 +195,25 @@ Parameters
Username to access phpIPAM server
+ + + +
+ validate_certs + +
+ boolean +
+ + +
    Choices: +
  • no
    • +
  • yes ←
    • +
+ + +
Is the TLS certificate of the phpIPAM server verified or not.
+ diff --git a/docs/plugins/vrf_module.rst b/docs/plugins/vrf_module.rst index 67a7e4a..ef7c62f 100644 --- a/docs/plugins/vrf_module.rst +++ b/docs/plugins/vrf_module.rst @@ -210,6 +210,25 @@ Parameters
Username to access phpIPAM server
+ + + +
+ validate_certs + +
+ boolean +
+ + +
    Choices: +
  • no
    • +
  • yes ←
    • +
+ + +
Is the TLS certificate of the phpIPAM server verified or not.
+
diff --git a/galaxy.yml b/galaxy.yml index fa8e9c6..4208425 100644 --- a/galaxy.yml +++ b/galaxy.yml @@ -3,7 +3,7 @@ name: "phpipam" description: Ansible Modules to manage phpIPAM installations authors: - "Christian Meißner " -version: "1.0.0" +version: "1.1.0" license: - "GPL-3.0-or-later" tags: diff --git a/plugins/doc_fragments/phpipam.py b/plugins/doc_fragments/phpipam.py index 41d7e5e..2f2649b 100644 --- a/plugins/doc_fragments/phpipam.py +++ b/plugins/doc_fragments/phpipam.py @@ -43,6 +43,11 @@ class ModuleDocFragment(object): description: Password of the user to access phpIPAM server required: true type: str + validate_certs: + description: Is the TLS certificate of the phpIPAM server verified or not. + required: false + type: bool + default: yes ''' ENTITY_STATE = ''' diff --git a/plugins/module_utils/phpipam_helper.py b/plugins/module_utils/phpipam_helper.py index 047cd37..4233915 100644 --- a/plugins/module_utils/phpipam_helper.py +++ b/plugins/module_utils/phpipam_helper.py @@ -64,6 +64,7 @@ def __init__(self, **kwargs): app_id=dict(required=True), username=dict(required=True), password=dict(required=True, no_log=True), + validate_certs=dict(type='bool', required=False, default=True), ) argument_spec.update(gen_args) argument_spec.update(kwargs.pop('argument_spec', {})) diff --git a/tests/test_playbooks/tasks/section.yml b/tests/test_playbooks/tasks/section.yml index 162b73f..ce23c71 100644 --- a/tests/test_playbooks/tasks/section.yml +++ b/tests/test_playbooks/tasks/section.yml @@ -16,4 +16,5 @@ show_vrf: "{{ section_show_vrf | default(omit) }}" show_supernets_only: "{{ section_show_supernets_only | default(omit) }}" dns_resolver: "{{ section_dns_resolver | default(omit) }}" + validate_certs: "{{ section_validate_certs | default(omit) }}" state: "{{ section_state | default('present') }}"