Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dotenv for environment variables #32

Open
angelocordon opened this issue Mar 12, 2019 · 3 comments
Open

Use dotenv for environment variables #32

angelocordon opened this issue Mar 12, 2019 · 3 comments
Assignees
Milestone

Comments

@angelocordon
Copy link
Contributor

angelocordon commented Mar 12, 2019

I think it might be worth looking into using dotenv to manage environment variables, like Sparkpost's API key. This seems to be the most compatible/reliable one I've seen for Meteor - https://atmospherejs.com/pauldowman/dotenv

The main problem statement here is simply a small inconvenience for now but I think could help future contributors in the long run. Currently, in order to get the authentication emails, we have to replace he password value in line 14 of dev-settings.json and ignore this when committing.

"password": "password",

Ideally, each contributor can have their own set of environment keys that doesn't checked in with git. I think using environment variables to manage these for us should help users get up and running easier and allow for better productivity.

I believe it might also give us a simpler way of running local versions as you probably shouldn't need to append --settings dev-settings.json when starting up anymore.

Of course this is a tiny optimization for now, but can be helpful in the future. Posting this here for discussion as we're going to be aware of this when deploying to Heroku as well.

@distalx
Copy link
Member

distalx commented Mar 23, 2019

Hi! @angelocordon

Ideally, each contributor can have their own set of environment keys that doesn't checked in with git. I think using environment variables to manage these for us should help users get up and running easier and allow for better productivity.

We already do have listed my-settings.json inside our .gitignore file for the same purpose. here

@angelocordon
Copy link
Contributor Author

Oh coo, thanks @distalx 👍 I think considering it was ignored in git, I didn't realize that something like that existed.

Anyways, going to close this question for now, definitely a pre-optimization.

@angelocordon
Copy link
Contributor Author

Reopening in association to #81

@angelocordon angelocordon self-assigned this May 19, 2019
@angelocordon angelocordon added this to the MVP v1.0.0 milestone May 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants