Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface contributions #137

Open
kibaekkim opened this issue May 28, 2020 · 3 comments
Open

Interface contributions #137

kibaekkim opened this issue May 28, 2020 · 3 comments

Comments

@kibaekkim
Copy link

I have implemented and maintained the interfaces to OOQP and SCIP. The interfaces may be incomplete but working fine for my own purpose. It must be better if the interfaces would be ported to and maintained in this repo. I can make a PR for that. Hopefully, review process can resolve any incomplete parts.

My question is: which branch should I use as a parent branch to make the PR?

I see that OSI is being refactorized now, which looks like a departure from the current stable version. Would it be OK to make the PR from stable/0.108?

@svigerske
Copy link
Member

No, use master.

@tkralphs
Copy link
Member

We have been a bit remiss in documenting contributions since the move to Github. For a substantial contribution like this, we should get some paperwork. Ideally, I would like to gave some kind of automated system for signing CLAs, e.g., this bot. Maybe we could use this as a test case.

@mjsaltzman
Copy link
Contributor

mjsaltzman commented May 28, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants