Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.4.5 not backward compatible with 3.4.4 - Added optional chaining operator #62

Open
giuseppeturelli opened this issue Nov 28, 2024 · 2 comments

Comments

@giuseppeturelli
Copy link

giuseppeturelli commented Nov 28, 2024

Hi,

Just FYI we noticed that version 3.4.5 is not fully backward compatible with 3.4.4 as in our project we are still using ecmascript2015 which does not support optional chaining operator (holidays.js line 388, commit 4b11197).

@JonathanVelkeneers
Copy link

Same issue here, our builds suddenly broke.
We are using date-holidays on 3.21.3, and due to the loose version locking in it's package.json it automatically started using 3.4.5 of this package.

If anyone stumbles on this issue whilst using date-holidays, you can apply a temp fix by adding
"date-holidays-parser": "3.4.4"
to your package.json

@commenthol
Copy link
Owner

@giuseppeturelli Sorry for breaking your build. I did not thought about es2015 compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants