Update types for former defaultProps to be optional #3044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the type interface so that it is not mandatory to pass them
ByronDWall
requested review from
stephsprinkle,
jaikamat,
ddouglasz,
tylermorrisford and
misama-ct
and removed request for
a team
🦋 Changeset detectedLatest commit: fe9253d The changes in this PR will be included in the next version bump. This PR includes changesets to release 99 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tdeekens
reviewed
Jan 17, 2025
| @@ -112,7 +112,7 @@ describe('generate README (for TS file)', () => { | |||
|
|
|||
| ## Description | |||
|
|
|||
| Render an Justice League | |||
| Render a Justice League | |||
There was a problem hiding this comment.
This makes the PR worthwhile.
| @@ -101,7 +101,7 @@ export const handleColumnsUpdate = ( | |||
| : selectedColumns; | |||
|
|
|||
| const columns = isSwap ? selectedColumns : availableColumns; | |||
| const draggedColumn = columns.find( | |||
| const draggedColumn = columns!.find( | |||
There was a problem hiding this comment.
Sorry, but if this is optionally don't we conditionally chain here?
There was a problem hiding this comment.
we know that availableColumns will always be [] because of the default param on line 134 - optional chaining is probably the better choice though
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for upgrading ui kit to react 19, it was necessary to remove all
defaultPropsin favor of passing a default param to the prop.This PR updates the types of any prop that has a default param to be optional so that it is not mandatory to pass the prop in consuming applications. This reduces the amount of refactoring that consumers will have to do to satisfy typechecking.