-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to crypton-x509 #6998
Comments
@juhp |
what |
Thanks I updated the description |
Was there anything bad with the old library name or what's the reason? |
I haven't seen a broad announcement yet but yesodweb/wai#931 has some more context. |
pushed amqp-utils-0.6.4.0 which uses crypton-connection and crypton-x509. Unfortunately there is to be waited for xtendo-org/rawfilepath#7 to be built cleanly. |
aws-sns-verify-0.0.0.3 released: https://hackage.haskell.org/package/aws-sns-verify-0.0.0.3/dependencies |
I don't think the crypton-x509 is so critical to upgrade to, given that Kazu Yamamoto has uploader rights to x509, as you can see on hackage. So I am not sure what this issue is tracking, since both of those packages can co-exist. |
@ysangkok I'm pretty sure x509 is in the set of packages that Vincent has asked be abandoned. crypton-x509 is a replacement the same way crypton is. I doubt Kazu forked the repo/package just to keep updating the original. Getting everyone to switch ahead of time is a good proactive move. I guess we can just ask @kazu-yamamoto directly if this is the right move. |
I don't maintain |
Yeah could probably close this now |
The list of packages currently still depending on x509 (not present) depended on by:
x509-store (not present) depended on by:
x509-validation (not present) depended on by:
I'll make a PR and try to remove as many of them as possible |
Closing, but note that we had to remove 2 additional packages that transitively depended on jwt (not present) depended on by:
|
it seems like crypton-x509's test suite is also depending on x509. i've made an issue: |
FWIW, I prepared a PR for Perhaps I am out of the loop with what's going on in the Haskell world, but it seems a big ask to just change security critical dependencies without much of an explanation for why that needs to happen and why I should trust the replacements. I followed through a few issues and came across haskell-infra/hackage-trustees#396 which doesn't seem to be resolved yet. |
@mbg It's unfortunate, but the summary of it all is that Vincent doesn't want to pass on maintainership of the packages. The crypton packages are maintained by Kazu Yamamoto, and he already maintains a lot of notable packages, so you're probably already trusting him. See
Considering that cryptonite has bugs that are fixed in crypton, I think it's reasonable to switch. And it seems excessively conservative to stick with something just because it's what you're already depending on. There are open issues with cryptonite. |
crypton-x509* is replacing the x509* libraries.
Note the x509* library are still in Stackage Nightly at this time - this is a first heads-up
x509 (Grandfathered dependencies) (not present) depended on by:
x509-store (Grandfathered dependencies) (not present) depended on by:
x509-system (Grandfathered dependencies) (not present) depended on by:
x509-validation (Grandfathered dependencies) (not present) depended on by:
Please migrate your packages to crypton-x509*
The text was updated successfully, but these errors were encountered: