Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRITICAL:cwlprov.tool:Path "data/..." in manifest "manifest-sha1.txt" is unsafe #19

Open
steninidak opened this issue Oct 21, 2022 · 1 comment

Comments

@steninidak
Copy link

Hello,

When trying to validate CWL provenance folder using cwlprov python tool, I get the error in subject, which deals with the usage of unsafe SHA1 checksums. As far as I have noticed into cwltool, the only supported SHA by CWL at the moment is SHA1 (Am I right?).

Is there any way to bypass that critical error or to switch to SHA256 or SHA512?

In the same provenance folder, there are also 2 tagmanifest files for SHA256 and SHA512.

Thank you in advance

@mr-c
Copy link
Member

mr-c commented Oct 24, 2022

Hello @steninidak ; can you provide a reproducible example? cwltool --provenance should be providing the additional hash types

https://github.com/common-workflow-language/cwltool/blob/72e4ffb7814ec846c12ec15df82a4243654fe053/cwltool/provenance.py#L99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants