Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken i18nalized url #10

Open
paolobrasolin opened this issue May 9, 2022 · 1 comment
Open

Fix broken i18nalized url #10

paolobrasolin opened this issue May 9, 2022 · 1 comment
Assignees

Comments

@paolobrasolin
Copy link
Member

paolobrasolin commented May 9, 2022

When using extra languages (DE in our case) and a custom baseUrl the relativized URLs are wrong. In many places the baseUrl gets doubled because the templates are a bit careless with relativization; e.g. a baseUrl of \all4ling leads to \all4ling\all4ling\de\whatever instead of \all4ling\de\whatever.

I almost got it working with 11a04de but the i18n path fragment ended up missing in some places, e.g. the top bar.

Still, that's a good starting point.

Ultimately i reverted it, so you can (at the time of writing) see the faulty behaviour deployed at https://commul.github.io/all4ling while the correct behaviour can be seen at https://all4ling.eurac.edu/

(This is the only blocker to switching from GitLab to GitHub, fyi @iiegn.)

@iiegn
Copy link
Member

iiegn commented May 9, 2022

ah, i see. i remember, i had to tweak the template a little to get it working on local gitlab. although, it's currently not working there (without going through the rev-proxy)... ok, so (and this seems like a good idea anyway) we should get ourselves a staging area. is this possible with github - and could

  • @paolobrasolin configure a staging area
  • @iiegn set up rev-proxy for staging
    ..and then we'll continue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants