Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

im2deep dependency broken #204

Closed
MatthewThe opened this issue Nov 26, 2024 · 1 comment · Fixed by #205
Closed

im2deep dependency broken #204

MatthewThe opened this issue Nov 26, 2024 · 1 comment · Fixed by #205
Assignees
Labels
Milestone

Comments

@MatthewThe
Copy link

The latest version of im2deep (v0.3.1) moved the im2ccs function from im2deep.calibrate to im2deep.utils.

This results in the following error when trying to run ms2rescore:

ImportError: cannot import name 'im2ccs' from 'im2deep.calibrate'

This can easily be fixed by changing the import to from im2deep.utils import im2ccs in ms2rescore/feature_generators/im2deep.py. This would then obviously also require bumping the version requirement for im2deep.

@RalfG RalfG linked a pull request Dec 4, 2024 that will close this issue
@RalfG
Copy link
Member

RalfG commented Dec 4, 2024

Hi @MatthewThe,

Thanks for letting us know! This will be fixed in https://github.com/compomics/ms2rescore/releases/tag/v3.1.4, which is currently being built.

Best,
Ralf

@RalfG RalfG closed this as completed Dec 4, 2024
@RalfG RalfG added the bug label Dec 4, 2024
@RalfG RalfG added this to the v3.1.4 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants