Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support <details> and <summary> in markdown #951

Closed
yookoala opened this issue Sep 19, 2018 · 3 comments
Closed

Feature Request: Support <details> and <summary> in markdown #951

yookoala opened this issue Sep 19, 2018 · 3 comments
Labels

Comments

@yookoala
Copy link
Contributor

<details> and <summary> are tags introduced in HTML5 as a way to enclose collapsible / expandable widgets. Both Github and Gitlab support using them as inline HTML. And they are parsed and displayed properly.

People uses them to enclose less important information, such as advanced examples. And by using them, the display of README.md are much easier to read.

Please support them as part of the inline html support for displaying README.md for packages.

@yookoala
Copy link
Contributor Author

See also: cebe/markdown#163

Seldaek added a commit that referenced this issue Nov 16, 2018
@Seldaek
Copy link
Member

Seldaek commented Nov 16, 2018

I tried allowing details/summary tags, but that seems to make HTMLPurifier fail hard.. I don't have much time to investigate now but I'd suggest you have a look at that too if you care enough to get this working.

yookoala added a commit to yookoala/packagist that referenced this issue Nov 17, 2018
yookoala added a commit to yookoala/packagist that referenced this issue Nov 17, 2018
@yookoala
Copy link
Contributor Author

yookoala commented Nov 17, 2018

@Seldaek: I've drafted a PR based on your original code in e03934e. Please check it out. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants