-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra dependencies to recipe #55
Comments
Having a batteries included approach is also undesirable as it can add up to many unused packages and I wouldn't be in favor of extending the current repository since pydantic is lightweight. conda-forge generally takes the |
@dgasmith Then could you please consider creating a |
Is there no way to install |
@samuelcolvin There is, but if I declare |
That would be the same in pypi/pip land and seems extremely unlikely. I don't think it's sufficient reason to create a new package. Although I guess no one is stopping you creating it...? |
No, in pip land, I can declare a dependency on |
@samuelcolvin conda in general doesn't support optional dependancies (apart from making more packages). @jwodder I don't have time at the moment to make another recipe, conda-forge is open submission. Happy to review/maintain another package! |
Just my two cents: The easiest approach is to create a multi-output recipe like here: https://github.com/conda-forge/sagemaker-inference-toolkit-feedstock/blob/master/recipe/meta.yaml The package should then be called base-extra and just depend on base + extras without having any content itself. |
I am attempting to add a recipe to conda-forge that depends on pydantic with the
[email]
extra. However, conda does not support extras, and email-validator is not listed as a runtime dependency in pydantic's conda-forge recipe. I would like to request that email-validator (and python-dotenv, for completeness) be added to the runtime dependencies in pydantic's conda-forge recipe so that they will be available to packages that depend on pydantic. (The alternative course of action, in which projects that need extras explicitly list the packages in the extras in their recipes, would shift responsibility for keeping pydantic's dependencies up to date from the maintainers of this recipe to the maintainters of all recipes that depend on pydantic, which seems undesirable.)The text was updated successfully, but these errors were encountered: