Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more specific command to list environments #287

Closed
wants to merge 1 commit into from

Conversation

patricklabatut
Copy link

Description

This small change uses the more specific env list command instead of info to retrieve the list of environments. micromamba doesn't dump environments in the output of the info --json command, so while the change doesn't modify anything when using standard conda, it unblocks using conda-pack together with micromamba.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @patricklabatut.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#823), and ping the bot to refresh the PR.

Copy link
Collaborator

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this but I need a signed CLA for this.

@patricklabatut
Copy link
Author

patricklabatut commented Sep 24, 2023

@xhochy Thanks! Sure, I had actually signed the CLA shortly after seeing this being required. It looks to me the matching PR in the infrastructure repo did acknowledge that (with the cla-signed label) but is still lacking a review stamp...

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Sep 26, 2023
@xhochy
Copy link
Collaborator

xhochy commented Nov 10, 2023

@patricklabatut Can you look into the failures here? They are related to your change.

Copy link

Hi there, thank you for your contribution!

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this pull request to remain open please:

  1. Rebase and verify the changes still work
  2. Leave a comment with the current status

NOTE: If this pull request was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Nov 10, 2024
@github-actions github-actions bot added the stale::closed [bot] closed after being marked as stale label Dec 11, 2024
@github-actions github-actions bot closed this Dec 11, 2024
@github-actions github-actions bot closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA stale::closed [bot] closed after being marked as stale stale [bot] marked as stale due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants