Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub token to conda/constructor #920

Closed
2 tasks done
marcoesters opened this issue Apr 22, 2024 · 2 comments
Closed
2 tasks done

Add GitHub token to conda/constructor #920

marcoesters opened this issue Apr 22, 2024 · 2 comments
Assignees
@kenodegard
Labels
in-progress issue is actively being worked on locked [bot] locked due to inactivity source::anaconda created by members of Anaconda, Inc. type::task indicates a change that doesn't pertain to the code itself, e.g. updating CI/CQ, rebuilding package

Comments

@marcoesters
Copy link
Contributor

Checklist

  • I added a descriptive title
  • I searched open requests and couldn't find a duplicate

What is the idea?

The idea is to automatically report test failures when pushing to main as an issue at the constructor project similar to what is done at conda-libmamba-solver: https://github.com/conda/conda-libmamba-solver/blob/efa3b84141e4ff777928aaae952fac417b059091/.github/workflows/tests.yml#L680-L690

This requires a token with the permission to create issues.

Why is this needed?

To support key-vault-based code signing tools like AzureSignTool, repository secrets are needed to do integration tests. These are not available to contributions from a fork so that these tests need to be skipped. This can cause failures when merging to main. For more context, see the issue at constructor: conda/constructor#775

conda-libmamba-solver creates issues on test failures to make them more visible. The same should be done for constructor so that problem can be addressed promptly.

What should happen?

A token should be added as a repository secret to conda/constructor.

Additional Context

No response
@marcoesters marcoesters added the type::feature request for a new feature or capability label Apr 22, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in 🧭 Planning Apr 22, 2024
@kenodegard kenodegard added in-progress issue is actively being worked on type::task indicates a change that doesn't pertain to the code itself, e.g. updating CI/CQ, rebuilding package source::anaconda created by members of Anaconda, Inc. and removed type::feature request for a new feature or capability labels Apr 22, 2024
@kenodegard kenodegard moved this from 🆕 New to 🏗️ In Progress in 🧭 Planning Apr 22, 2024
@kenodegard
Copy link
Contributor

CONSTRUCTOR_ISSUES repository secret created and added to conda/constructor.

@kenodegard kenodegard moved this from 🏗️ In Progress to 👀 In Review in 🧭 Planning Apr 22, 2024
@marcoesters marcoesters mentioned this issue Apr 22, 2024
Merged
3 tasks
@marcoesters
Copy link
Contributor Author

Thank you! The token works

@github-project-automation github-project-automation bot moved this from 👀 In Review to 🏁 Done in 🧭 Planning Apr 23, 2024
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Oct 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kenodegard kenodegard

Labels
in-progress issue is actively being worked on locked [bot] locked due to inactivity source::anaconda created by members of Anaconda, Inc. type::task indicates a change that doesn't pertain to the code itself, e.g. updating CI/CQ, rebuilding package
Projects
🧭 Planning
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kenodegard @marcoesters