Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please update pydantic support to 2.X #166

Closed
2 tasks done
opoplawski opened this issue Dec 3, 2023 · 2 comments · Fixed by #169
Closed
2 tasks done

Please update pydantic support to 2.X #166

opoplawski opened this issue Dec 3, 2023 · 2 comments · Fixed by #169
Labels
locked [bot] locked due to inactivity type::feature request for a new feature or capability

Comments

@opoplawski
Copy link

Checklist

  • I added a descriptive title
  • I searched open requests and couldn't find a duplicate

What is the idea?

Fedora is shipping pydantic 2.X, it would be helpful for packaging conda-menuinst if menuinst would support that. Thank you.

Why is this needed?

No response

What should happen?

No response

Additional Context

No response
@opoplawski opoplawski added the type::feature request for a new feature or capability label Dec 3, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in 🧭 Planning Dec 3, 2023
@jaimergp
Copy link
Contributor

jaimergp commented Dec 3, 2023

Hi! pydantic is not a runtime requirement. It's only used to regenerate the JSON schemas shipped in the repo, and for some tests, but end users won't need it. Is that helpful?

@opoplawski
Copy link
Author

We prefer to run package tests when building Fedora packages. It's not a hard requirement, but that's why I made the request.

@jaimergp jaimergp mentioned this issue Dec 10, 2023
Merged
3 tasks
@github-project-automation github-project-automation bot moved this from 🆕 New to 🏁 Done in 🧭 Planning Dec 11, 2023
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Sep 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
locked [bot] locked due to inactivity type::feature request for a new feature or capability
Projects
🧭 Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add compat for pydantic v2 jaimergp/menuinst
2 participants
@opoplawski @jaimergp