Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all the pages responsive #5

Open
consci210 opened this issue Mar 25, 2023 · 9 comments
Open

Make all the pages responsive #5

consci210 opened this issue Mar 25, 2023 · 9 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers up-for-grabs beginner friendly

Comments

@consci210
Copy link
Owner

consci210 commented Mar 25, 2023

Update !!

All pages are now fully responsive πŸ“±πŸ’»πŸ–₯️. However, we still need to do a thorough check πŸ” to make sure that there are no minor issues πŸ•΅οΈβ€β™€οΈ like misplaced buttons , or other elements.
🚫 Therefore, the issue is not yet closed, PRs are still accepted to fix issues with styling .

@consci210 consci210 added enhancement New feature or request good first issue Good for newcomers up-for-grabs beginner friendly labels Mar 25, 2023
@consci210
Copy link
Owner Author

consci210 commented Mar 25, 2023

I have already applied the stylings for the desktop version , add responsiveness to the pages in order for them to be suitable for devices with smaller screens ,You can find the UI designs in the "mockups" directory

@vedamruta
Copy link

Hi, please assign this issue to me, I have studied the requirement and started with the work. Thank you in advance :)

@consci210
Copy link
Owner Author

There you go . Let me know if you need any additional info or file .

@consci210 consci210 pinned this issue Mar 25, 2023
@consci210 consci210 unpinned this issue Mar 25, 2023
@vedamruta
Copy link

Hii @consci210 done with responsiveness.
Please have a look at the attached screenshots :)
desktop view
mobile view
tablet view

@consci210
Copy link
Owner Author

@vedamruta πŸ‘ Looks great! Just needs a little bit of touchups.
But, may I ask, did you create new components and separate CSS or did you add media queries to the existing CSS stylesheet?

@vedamruta vedamruta mentioned this issue Mar 26, 2023
@vedamruta
Copy link

@vedamruta πŸ‘ Looks great! Just needs a little bit of touchups. But, may I ask, did you create new components and separate CSS or did you add media queries to the existing CSS stylesheet?

Ohh sorry I didn't saw your message and made a pull request.
Yeah, I have did the final formatting and found that the text wasn't center aligned and fixed that now.

What I did ??
I have created new components in index.html and styled them in index.css using CSS classes and IDs.

@consci210
Copy link
Owner Author

@vedamruta Oh, but this is a React app! You don't need to create a new index.html file. Instead, you can add your components inside the HomePage.jsx component.
Don't worry, though, we won't let your efforts go to waste! Since you've already done the styling work, maybe we could add your styles to the existing CSS file and modify the elements and classNames in the HomePage.jsx component accordingly.

Thank you for your hard work !

@vedamruta
Copy link

Oh actually I am not yet familiar to React.js
I would start learning that soon.
Thank you for the opportunity presented ✨

@consci210
Copy link
Owner Author

It's great to hear that you're planning to start learning React.js soon. I'm sure you'll find it to be an exciting and powerful framework. In the meantime, please don't hesitate to reach out on discord if you have any questions or if there's anything else I can help you with. Thank you for helping me out on this project, and I look forward to connecting with you again in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers up-for-grabs beginner friendly
Projects
None yet
Development

No branches or pull requests

2 participants