-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add set operations #6
Comments
I think we should rename the join methods to their appropriate set operation name. |
It's worth noting that these are established terms in relational algebra. I have no strong feelings on the names, otherwise. |
Is there a difference other than the names? I've been thinking that it's silly for every (ordered) set implementation to define its own Note that this is different from optimized set operations that return a new set (e.g. |
That... is an interesting idea. It's not clear to me that the optimal impl is necessarily blanket-able in general, though. |
Another reason I favor the generic iterator adaptors here is that it avoids the theoretical combinatoric problem with iteration modes. Right now, the the sets in |
Not to mention the bounded iterators. |
The traits can be extended with additional methods that yield the difference and symmetric difference between two ordered iterators. The union is already handled by
outer_join
, and the intersection is already handled byinner_join
.The text was updated successfully, but these errors were encountered: