Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Does this support private image registries? #32

Open
danielloader opened this issue Aug 15, 2024 · 1 comment
Open

[Question] Does this support private image registries? #32

danielloader opened this issue Aug 15, 2024 · 1 comment

Comments

@danielloader
Copy link

danielloader commented Aug 15, 2024

Thanks for making this, and despite a mainline tree implementation of this brewing I'm glad someone has made this!

It'll take years before I see it on EKS anyway.

So to reiterate the title, does this support imagePullSecrets?

@danielloader danielloader changed the title [Question [Question] Does this support private image registries? Aug 15, 2024
@vsoch
Copy link
Member

vsoch commented Aug 15, 2024

Not currently, but that would be a fairly easy addition. You would want to retrieve the secret via likely a secret -> environment variable and then add to the requests here.

func pullBlob(repo *remote.Repository, blobRef string, filename string) (fetchErr error) {
PRs welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants