Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unregister function for subsystem #12

Open
vsoch opened this issue Feb 29, 2024 · 1 comment
Open

feat: add unregister function for subsystem #12

vsoch opened this issue Feb 29, 2024 · 1 comment

Comments

@vsoch
Copy link
Member

vsoch commented Feb 29, 2024

An unregister function should delete a cluster from the in memory graph database. I'm curious if go garbage collecting will handle this as long as an object (the cluster root) is disconnected from any running context. I think I can test that with this tool: https://dave.cheney.net/2014/07/11/visualising-the-go-garbage-collector

E.g.,:

  1. Run server with this visualizer
  2. Register a new cluster
  3. Unregister and see if the unregister reflects that it was cleaned up

What I don't want is to have dangling objects (vertices and edges) left over somewhere, and it would be less ideal to have to manually go through the graph and delete things.

@vsoch
Copy link
Member Author

vsoch commented Feb 29, 2024

This tool appears to be deprecated so I wound up using standard runtime and then manual GC, and it does look like we are cleaning up. I'll keep this in mind moving forward.

image

Renaming the title here to reflect adding an unregister function to delete a particular subsystem cluster component.

@vsoch vsoch changed the title Test garbage collection with unregister function feat: add unregister function for subsystem Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant