Possible incorrect use of exported resource

[nick-fox]

An exported resource is causing duplicate resource.

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: A duplicate resource was found while collecting exported resources, with the type and title Metricbeat::Modulesd[system]

An exported resource declaration specifies a desired state for a resource, and publishes the resource for use by other nodes. It does not manage the resource on the target system. Any node, including the node that exports it, can collect the exported resource and manage its own copy of it.
See

puppet-metricbeat/manifests/config.pp

Lines 73 to 78 in 0b9c772

	# Create modules.d files that exist in hiera then collect any created via exported resources
	$module_templates_real = hiera_array('metricbeat::module_templates', $metricbeat::module_templates)
	$module_templates_real.each |$module| {
	@@metricbeat::modulesd { $module: }
	}
	Metricbeat::Modulesd <<||>>

I think you should be using create_resources
Converts a hash into a set of resources and adds them to the catalog.
See

[efoft]

Agree, I hit the same issue. If more than one node applies this manifest within the same puppetserver.

[braddeicide]

+1

[rogermartensson]

Is this fix planned to be included in a future version?
I noticed that the PR is failing.

[smoeding]

It's probably sufficient to turn the double @@ into a single @ here.

As already mentioned the double @@ creates exported resources that can be picked up by other nodes. I don't see any use for node2 to create a metricbeat config entry that node1 created.

Using a single @ will create virtual resources. These virtual resources must be collected (done here using <||>) to be realized. Now this could actually make sense here. A profile or role class could create virtual resources for items managed by the profile or role. These virtual resources would be ignored on servers that do not also include metricbeat. But if metricbeat is included then these resources would also be realized and added to the metricbeat config.

Obviously removing the @@ would directly create the resources and the collection would not be needed.

[couloum]

Hi,

I had the same issue while trying to use this module on multiple nodes. I applied @smoeding fix and it worked like a charm.

Is the fix planned for a future release?

Thanks

[cdenneen]

@corey-hammerton this is a pretty big issue. Any solution for fixing this?

[cdenneen]

#59 added with @smoeding suggestion

[cdenneen]

@corey-hammerton Either suggestion is fine #48 or @smoeding that I did in #59 (it doesn't collect and realize those virtual resources so this would be done outside this class)

[corey-hammerton]

I merged #59 but am unable to verify the fix. Travis CI integration is now broken, this was unverified because this project is not under active development.