Format of hardcoded error messages regarding security

[MikeMcC399]

Avoid duplicates

• Bug is not mentioned in the FAQ
• Bug is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
• Bug is not already reported in another issue
  See also Ursache: 2000 - etwas ist schiefgelaufen. #1214 (comment)

Technical details

• App version: 1.10.1 branch release/1.11.x

Describe the bug

In the following string, the message is not capitalised:

cwa-app-android/Corona-Warn-App/src/main/java/de/rki/coronawarnapp/exception/CwaWebSecurityException.kt

Line 8 in 4f76644

"an error occurred while trying to establish a secure connection to the server",

In the following string, the message is not capitalised and there is no space between the words "refer" and "to"

In 1.10.1

cwa-app-android/Corona-Warn-App/src/main/java/de/rki/coronawarnapp/exception/CwaSecurityException.kt

Lines 8 to 9 in 4f76644

	"something went wrong during a critical part of the application ensuring security, please refer" +
	"to the details for more information",

In release/1.11.x

cwa-app-android/Corona-Warn-App/src/main/java/de/rki/coronawarnapp/exception/CwaSecurityException.kt

Lines 8 to 9 in a36cf7e

	"something went wrong during a critical part of the application ensuring security, please refer" +
	" to the details for more information",

Steps to reproduce the issue

Code inspection only.

Expected behaviour

The error message in
CwaWebException.kt
should be formatted consistent with the capitalisation of other similar error message in the app:

The error message in
CwaSecurityException.kt
should be capitalised and contain a space between the words "refer" and "to".

Possible Fix

Capitalise the first word in the error message string of CwaWebException.kt
"an error occurred while trying to establish a secure connection to the server",
to
"An error occurred while trying to establish a secure connection to the server",

Capitalise the first word in the error message string of
CwaSecurityException.kt and add a space at the end of the string so that
"something went wrong during a critical part of the application ensuring security, please refer" +
becomes
"Something went wrong during a critical part of the application ensuring security, please refer" +

Additional context

Please let me know if the Open Source Team would like a pull request for the above suggested changes and if so what the target branch should be (release/1.n.x).

---

EXPOSUREAPP-4655

[PhilippNowak96]

Missing space is already fixed with 1.11, see

cwa-app-android/Corona-Warn-App/src/main/java/de/rki/coronawarnapp/exception/CwaSecurityException.kt

Lines 8 to 9 in a36cf7e

	"something went wrong during a critical part of the application ensuring security, please refer" +
	" to the details for more information",

[MikeMcC399]

@PhilippNowak96

Missing space is already fixed with 1.11

Thank you for checking! Whilst I was writing this issue I had a nagging thought that I ought to check later branches, but since I had reported the problem in #1214 (comment) and there was no feedback there I thought that no action was being taken. Well I was wrong to make that assumption!

I have updated the issue description now accordingly.

[MikeMcC399]

PR #2121 created.

[dsarkar]

@MikeMcC399 Feedback: Quote:

"Translated text needs to be fixed by the translator not via community PR"

[MikeMcC399]

@dsarkar

"Translated text needs to be fixed by the translator not via community PR"

This is not translated text, which would be in "https://github.com/corona-warn-app/cwa-app-android/tree/main/Corona-Warn-App/src/main/res/values[-language]/strings.xml".

These are hard-coded, non-translated, English-language-only error messages which are controlled by the software developers, not by the translation process. The texts are in .kt (kotlin) source files, not strings.xml files.

We can leave it to the developers to decide if they want to accept the PR #2121 or reject it.

[dsarkar]

@MikeMcC399

We can leave it to the developers to decide if they want to accept the PR #2121 or reject it.

Indeed. ;-)

[d4rken]

Closed via #2121