Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock UI - Welcome Screen #4

Open
6 tasks
karalabe opened this issue Mar 17, 2020 · 2 comments
Open
6 tasks

Mock UI - Welcome Screen #4

karalabe opened this issue Mar 17, 2020 · 2 comments
Labels
area:ui User interface work help wanted Extra attention is needed

Comments

@karalabe
Copy link
Member

The welcome screen is aimed to be the landing page for the app. I'm kind of happy with how it looks at the moment. Of course tweaks and polishes are always welcome.

  • The most essential information I'd like it to convey are a description of what the app is/does and an emphasis that it's private/secure by design. If anyone has suggestions on better wording, content that should be added/removed, opinions welcome.
  • Like all other screens, this too is currently a hacky mock-up code wise (check WelcomeScreen in https://github.com/coronanet/rn-coronanet/blob/master/App.js). I'd be happy for help on getting it into a semi final/decent shape. This would entail:
    • Move the type into its own separate file.
    • I'm unsure how the layout responsiveness behaves if the screen is not large enough? I think currently it just overflows on both the top and the bottom. That would be bad since we need the button visible. In that case, we should only push upwards. Maybe add a fallback scrollbar for some edge cases?
    • No idea what happens in landscape mode or even what should happen in that case. Ideas?
    • The code in general was written by me - someone with 0 UI, RN and mobile experience. Please rewrite anything that would make sense.

The welcome screen looks like this as of March 15, 2020:

Screenshot_20200315-183210_CoronaNet

@karalabe karalabe added help wanted Extra attention is needed area:ui User interface work labels Mar 17, 2020
@karalabe karalabe added this to the Phase 0: Mock UI milestone Mar 17, 2020
@karalabe karalabe mentioned this issue Mar 17, 2020
9 tasks
@daodesigner
Copy link
Contributor

image

@0mkara
Copy link
Contributor

0mkara commented Mar 22, 2020

  • I'm unsure how the layout responsiveness behaves if the screen is not large enough? I think currently it just overflows on both the top and the bottom. That would be bad since we need the button visible. In that case, we should only push upwards. Maybe add a fallback scrollbar for some edge cases?

PR #7 does some fundamental restructure of the components. Attends the above issue. Also enabled Create user functionality.
Screenshot_1584906647

Please review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ui User interface work help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants