Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Data selection time should be tracked independent of query priority #6484

Open
yeya24 opened this issue Jan 6, 2025 · 0 comments
Open

Query: Data selection time should be tracked independent of query priority #6484

yeya24 opened this issue Jan 6, 2025 · 0 comments
Labels
component/querier component/query-frontend type/bug

Comments

@yeya24
Copy link
Contributor

yeya24 commented Jan 6, 2025

Describe the bug

If query priority is disabled, rejectQueryOrSetPriority is returned immediately

cortex/pkg/querier/tripperware/query_attribute_matcher.go

Line 21 in 12412e6

return nil

Then the data selection min and max time are not set in the request stats.

cortex/pkg/querier/tripperware/query_attribute_matcher.go

Line 43 in 12412e6

reqStats.SetDataSelectMaxTime(maxTime)

Data selection range should be tracked even of query priority is disabled for query stats purpose.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/querier component/query-frontend type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yeya24