Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credential-less auth should be explicit opt-in #155

Open
timkelty opened this issue Oct 6, 2022 · 0 comments
Open

Credential-less auth should be explicit opt-in #155

timkelty opened this issue Oct 6, 2022 · 0 comments
Assignees
Labels

Comments

@timkelty
Copy link
Contributor

timkelty commented Oct 6, 2022

Currently "credential-less" auth is triggered by having an empty key or secret: https://github.com/craftcms/aws-s3/blob/main/src/Fs.php#L437-L472

A better/safer approach would be to have an explicit option whether or not to use credentials.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants