[Bug] Error Handling for patchAssetIntoDom Function in base.html

[wendy640]

Description

The patchAssetIntoDom function currently lacks error handling for network issues and HTTP response errors. This can lead to silent failures, negatively impacting user experience and making debugging difficult.

Reproduction

1. Call the patchAssetIntoDom function with an invalid asset path or an unreachable URL.
2. Observe that no error message is displayed in the console.
3. Check if any subsequent code that relies on the loaded asset fails silently.

Note code:

legaldb/legal_db/templates/legal_db/base.html

Lines 29 to 42 in 83e0303

	const patchAssetIntoDom = (asset, version=null) => {
	const ajax = new XMLHttpRequest();
	ajax.open("GET", getFullyQualifiedUrl(asset, version), true);
	ajax.onload = () => {
	var div = document.createElement("div");
	// Render SVG in the page
	div.innerHTML = ajax.responseText;
	div.style.display = 'none';
	document.body.insertBefore(div, document.body.childNodes[0]);
	}
	ajax.send();
	}
	patchAssetIntoDom('assets/logos/cc/logomark.svg');

Expectation

I expected to see error messages in the console if the asset fails to load, either due to a network issue or an HTTP error status. This would help identify problems more quickly and improve the overall reliability of the application.

Environment

• Device: (eg. iPhone Xs; laptop)
• OS: (eg. iOS 13.5; Fedora 32)
• Browser: (eg. Safari; Firefox)
• Version: (eg. 13; 73)
• Other info: (eg. display resolution, ease-of-access settings)

Additional context

• creativecommons/vocabulary: A cohesive system of design for Creative Commons

Resolution

• I would be interested in resolving this bug.

[TimidRobot]

🚧 status: blocked Blocked & therefore, not ready for work as I expect this issue will be resolved by migrating this project to the current Vocabulary design system:

• creativecommons/vocabulary: A cohesive system of design for Creative Commons