Add the Location Tag Binding resource #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akerone
requested review from
ulucinar,
sergenyalcin and
turkenf
as code owners
|
/test-examples="examples/tags/v1beta1/locationtagbinding.yaml" |
Signed-off-by: akerone <[email protected]>
Signed-off-by: akerone <[email protected]>
…tead of a Project (global) Signed-off-by: akerone <[email protected]>
Signed-off-by: akerone <[email protected]>
Signed-off-by: akerone <[email protected]>
Signed-off-by: akerone <[email protected]>
Signed-off-by: akerone <[email protected]>
|
Hi, I've changed references to an example project number to |
|
/test-examples="examples/tags/v1beta1/locationtagbinding.yaml" |
|
Hi, I've just realized that all resources in the TagBinding example have the |
Manual testing results:Apply:$ k apply -f examples/tags/v1beta1/locationtagbinding.yaml
locationtagbinding.tags.gcp.upbound.io/binding created
v2service.cloudrun.gcp.upbound.io/default created
tagkey.tags.gcp.upbound.io/key created
tagvalue.tags.gcp.upbound.io/value created
$ k get managed
NAME SYNCED READY EXTERNAL-NAME AGE
v2service.cloudrun.gcp.upbound.io/default True True default 93s
NAME SYNCED READY EXTERNAL-NAME AGE
locationtagbinding.tags.gcp.upbound.io/binding True True REDACTED_LOCATION/tagBindings/%2F%2Frun.googleapis.com%2Fprojects%2FREDACTED%2Flocations%2FREDACTED_LOCATION%2Fservices%2Fdefault/tagValues/REDACTED 94s
NAME SYNCED READY EXTERNAL-NAME AGE
tagkey.tags.gcp.upbound.io/key True True tagKeys/REDACTED 94s
NAME SYNCED READY EXTERNAL-NAME AGE
tagvalue.tags.gcp.upbound.io/value True True tagValues/REDACTED 94s
$ k annotate managed --all upjet.upbound.io/test=true --overwrite
locationtagbinding.tags.gcp.upbound.io/binding annotated
tagkey.tags.gcp.upbound.io/key annotated
tagvalue.tags.gcp.upbound.io/value annotated
The V2Service "default" is invalid: spec: Invalid value: "object": invalid data, expected a map for the provided schema with type=object evaluating rule: spec.forProvider.template is a required parameter
$ k get locationtagbindings.tags.gcp.upbound.io/binding -o yaml
(...)
conditions:
- lastTransitionTime: "2025-01-15T11:42:23Z"
reason: ReconcileSuccess
status: "True"
type: Synced
- lastTransitionTime: "2025-01-15T11:42:25Z"
reason: Available
status: "True"
type: Ready
- lastTransitionTime: "2025-01-15T11:42:24Z"
reason: Success
status: "True"
type: LastAsyncOperation
- lastTransitionTime: "2025-01-15T11:56:59Z"
reason: UpToDate
status: "True"
type: TestImport:# make run stopped
$ k --subresource=status patch locationtagbindings.tags.gcp.upbound.io/binding --type=merge -p '{"status":{"conditions":[]}}'
locationtagbinding.tags.gcp.upbound.io/binding patched
$ k describe locationtagbindings.tags.gcp.upbound.io binding
(...)
Status:
At Provider:
Id: REDACTED_LOCATION/tagBindings/%2F%2Frun.googleapis.com%2Fprojects%2FREDACTED_PROJECT%2Flocations%2FREDACTED_LOCATION%2Fservices%2Fdefault/tagValues/REDACTED_TAG_VALUE
(...)
# make run started
$ k get locationtagbindings.tags.gcp.upbound.io/binding -o yaml
(...)
status:
atProvider:
id: REDACTED_LOCATION/tagBindings/%2F%2Frun.googleapis.com%2Fprojects%2FREDACTED_PROJECT%2Flocations%2FREDACTED_LOCATION%2Fservices%2Fdefault/tagValues/REDACTED_TAG_VALUE
(...)
conditions:
- lastTransitionTime: "2025-01-15T12:21:08Z"
reason: Available
status: "True"
type: Ready
- lastTransitionTime: "2025-01-15T12:21:08Z"
reason: UpToDate
status: "True"
type: Test
- lastTransitionTime: "2025-01-15T12:21:08Z"
reason: Success
status: "True"
type: LastAsyncOperation
- lastTransitionTime: "2025-01-15T12:21:08Z"
reason: ReconcileSuccess
status: "True"
type: SyncedDelete:# Visually checked on console.cloud.google.com/run that the Cloud Run Service has the Tag
$ k delete locationtagbindings.tags.gcp.upbound.io binding
locationtagbinding.tags.gcp.upbound.io "binding" deleted
# Visually checked on console.cloud.google.com/run that the Cloud Run Service NO LONGER has the Tag |
turkenf
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Thank you, @akerone! 🎉
I really appreciate the detailed explanation of all the changes and test results you provided in this PR. Your clear documentation of the manual testing process was especially helpful. Even though this is your first contribution, you followed the guide diligently and did an excellent job. 👏 I'm looking forward to seeing more contributions from you in the future! 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #661
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Manual testing results
This is my first PR and I'm following the Configuring a resource guide as best as I can.