Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataplex lake iam #692

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Dataplex lake iam #692

wants to merge 2 commits into from

Conversation

Chloe-Carayon
Copy link

Description of your changes

This PR add new resources for Dataplex Lake IAM: LakeIAMPolicy, LakeIAMMember, LakeIAMBinding

Fixes: #687

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

I run manual tests as we are creating IAM policies for existing users so I commented all upjet.upbound.io/manual-intervention annotations.

Note: all roles used need to be Dataplex Predefined roles.

LakeIAMPolicy

export UPTEST_EXAMPLE_LIST="examples/dataplex/v1beta1/lakeiampolicy.yaml"
make e2e

Results:
iam_policy_0

kubectl create -f examples/dataplex/v1beta1/lakeiampolicy.yaml -n upbound-system
kubectl get managed

iam_policy_1

LakeIAMBinding

export UPTEST_EXAMPLE_LIST="examples/dataplex/v1beta1/lakeiambinding.yaml"
make e2e

Results:
iam_binding_1

kubectl create -f examples/dataplex/v1beta1/lakeiambinding.yaml -n upbound-system
kubectl get managed

iam_binding_0

LakeIAMMember

export UPTEST_EXAMPLE_LIST="examples/dataplex/v1beta1/lakeiammember.yaml"
make e2e

Results:
iam_member_1

kubectl create -f examples/dataplex/v1beta1/lakeiammember.yaml -n upbound-system
kubectl get managed

iam_member_0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar is a code owner

@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin is a code owner

@turkenf turkenf Awaiting requested review from turkenf turkenf is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request for Dataplex Lake IAM
1 participant
@Chloe-Carayon