Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: conflict when multiple api keys provided #569

Closed
wants to merge 3 commits into from
Closed

fix: conflict when multiple api keys provided #569

wants to merge 3 commits into from

Conversation

vovikhangcdv
Copy link
Contributor

Fixes #568 by:

  • Prioritize specific API key for certain explorer URLs
  • Fallback to using Etherscan later

@vovikhangcdv vovikhangcdv mentioned this pull request Jul 22, 2024
Open
@vovikhangcdv vovikhangcdv changed the base branch from master to dev July 22, 2024 10:02
@vovikhangcdv
Copy link
Contributor Author

hi @montyly @0xalpharush @bohendo can you have a look?

@elopez
Copy link
Member

elopez commented Dec 30, 2024

Hi @vovikhangcdv, thanks for the contribution! As this is no longer an issue now that we have migrated to the Etherscan v2 API (#574) which uses a single key, I'll close this PR.

@elopez elopez closed this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montyly montyly Awaiting requested review from montyly montyly is a code owner

@0xalpharush 0xalpharush Awaiting requested review from 0xalpharush

@bohendo bohendo Awaiting requested review from bohendo bohendo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conflict when multiple explorer API keys provided
2 participants
@vovikhangcdv @elopez