Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to disable log exception #78

Open
dengber opened this issue Mar 12, 2019 · 2 comments
Open

Add ability to disable log exception #78

dengber opened this issue Mar 12, 2019 · 2 comments

Comments

@dengber
Copy link

dengber commented Mar 12, 2019

The "try{...}catch(Exception e){log(e);throw;}" waved into code cause wrong line number of exception stack trace.

Please refer the flowing URL for detailed reason.
https://stackoverflow.com/questions/28481577/postsharps-onexceptionaspect-is-corrupting-the-stack-traces-line-numbers/28541633
https://support.postsharp.net/request/21942-exception-line-number-at-end-of

Can you add the ability to disable log exception when user prefer to disable it?

@csnemes
Copy link
Owner

csnemes commented Mar 17, 2019

Yes of course, I'll put it into the next iteration. Also I'll try to see if using the ExceptioDispatchInfo class can fix this problem.

@dengber
Copy link
Author

dengber commented Mar 18, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants