Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of deprecated torch.norm #2528

Closed
dhzdhd opened this issue Jul 14, 2023 · 3 comments
Closed

Use of deprecated torch.norm #2528

dhzdhd opened this issue Jul 14, 2023 · 3 comments

Comments

@dhzdhd
Copy link

dhzdhd commented Jul 14, 2023

The PyTorch examples in the Norms section of Preliminaries - Linear Algebra contain the usage of torch.norm.

According to torch docs torch.norm is deprecated and torch.linalg.vector/matrix_norm should be used.

I can help in contributing to fixing the issue if this is indeed a problem
@AnirudhDagar
Copy link
Member

Thanks @dhzdhd for raising the issue. Yeah, we'll welcome a PR with the fix that you already mention.

It would be great to check the usage of torch.norm throughout the book (search entire repo cmd+f) and replace wherever encountered.

@dhzdhd
Copy link
Author

dhzdhd commented Jul 14, 2023

Alright, i would like to work on this.

@dhzdhd
Copy link
Author

dhzdhd commented Jul 15, 2023

Unable to proceed due to d2l-ai/d2l-book#75

@dhzdhd dhzdhd closed this as completed Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AnirudhDagar @dhzdhd