Skip to content
This repository has been archived by the owner on Jan 18, 2025. It is now read-only.

From 100% to 99% #137

Closed
Roccobot opened this issue May 1, 2024 · 3 comments
Closed

From 100% to 99% #137

Roccobot opened this issue May 1, 2024 · 3 comments
Assignees

Comments

@Roccobot
Copy link

Roccobot commented May 1, 2024

Context

Browser: Vivaldi 6.7.3329.21 (arm64)

Operating System: macOS 14.4.1

Adblock Solution: Adguard extension

Description of Issue: I used to get a perfect 100%, now I get 99% (without changing my configuration)

Test Result: 99%

Test Log: log.txt

Confirmation

  • [×] I confirm that I have filled out all the necessary fields with enough detail to allow for the proper investigation and potential resolution of the issue.
Copy link

github-actions bot commented May 1, 2024

Hello @Roccobot, it looks like your issue is missing some required information:

  • Browser:
  • OS:
  • Adblock Solution
  • Description of Issue:
  • Test Result:
    Please update your issue to include this information.

1 similar comment
Copy link

github-actions bot commented May 1, 2024

Hello @Roccobot, it looks like your issue is missing some required information:

  • Browser:
  • OS:
  • Adblock Solution
  • Description of Issue:
  • Test Result:
    Please update your issue to include this information.

@d3ward
Copy link
Owner

d3ward commented May 8, 2024

My guess is that cosmetic_dynamic_ad doesn't have a specific rule to verify if feature works as expected.
Add these 2 rules in "User Rule" of Adguard extension and then it should be 100%

d3ward.github.io##.adbox.banner_ads.adsbox
d3ward.github.io##.textads

Note: If a cosmetic filter test fails, it simply means that the specific website being tested (in this case d3ward.github.io) isn't included in any of adblock's rules or lists.
It's important to note that this does not mean that cosmetic filtering fails on all websites or extension is bad
You can confirm this by visiting a popular, ad-rich site where you're unlikely to see any ad boxes.
The purpose of this test is to assess the functionality of the blocking feature, not to determine its scope or coverage

@d3ward d3ward closed this as completed May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants