Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

Automatic login after successful registration #15

Open
pcaversaccio opened this issue Feb 6, 2022 · 6 comments
Open

Automatic login after successful registration #15

pcaversaccio opened this issue Feb 6, 2022 · 6 comments
Labels
feature 💥 New feature or request frontend 🖥 Issues related to front-end

Comments

@pcaversaccio
Copy link
Member

Based on the user feedback we should evaluate whether to enable automatic login after successful email verification.

@pcaversaccio pcaversaccio added feature 💥 New feature or request frontend 🖥 Issues related to front-end labels Feb 6, 2022
@ttattl
Copy link
Contributor

ttattl commented Feb 22, 2022

@dachanh did you check the support from AWS? I do not think AWS support that due to the lack of security. From my side, I want to ignore it. Really dangerous in security @pcaversaccio .

@pcaversaccio
Copy link
Member Author

I don't understand the security risk @ttattl? Once the user enters the confirmation code in the fronted the user expects that he/she is logged in. Or in other words, why is this re-sign-in flow after the confirmation code entering more secure?

@ttattl
Copy link
Contributor

ttattl commented Feb 22, 2022

The code is used for activating the user in Cognito only. So there is a problem if the client wants to log in automatically, we need a token (generated from ID and password) to log in. AWS does not support us to generate the token to log in when we know the confirmation code.
Actually, whenever a client wants to log in, we need the acc ID and password. Therefore, the front-end has to store the password on the client-side, and this is a high-security risk.

@pcaversaccio
Copy link
Member Author

Ok, I do understand @ttattl - in theory, we could build the logic ourselves by having a flag in the user profile and letting him/her login automatically by disabling the verification logic from Cognito. But the complexity should not be underestimated as well as the security considerations to bypass maybe this. So let's stick for the moment to the current flow but I let this issue open for later considerations.

@pcaversaccio pcaversaccio transferred this issue from another repository Feb 23, 2022
@ttattl
Copy link
Contributor

ttattl commented Mar 2, 2022

Not considered in this quarter. Keep it.

@pcaversaccio
Copy link
Member Author

Recheck in the next phase May 2022.

@locpnh1995 locpnh1995 assigned locpnh1995 and unassigned locpnh1995 Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature 💥 New feature or request frontend 🖥 Issues related to front-end
Projects
None yet
Development

No branches or pull requests

3 participants