You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think it would be clearer to rename identifier to params or perhaps data in the create method (create(channel, identifier:, autoSubscribe:, bufferActions:). I see that the underlying API send identifier to the backend, but since name is a standalone parameter, I think it would make sense to abstract it a little bit more.
The text was updated successfully, but these errors were encountered:
Hi @danielrhodes,
I think it would be clearer to rename
identifier
toparams
or perhapsdata
in the create method (create(channel, identifier:, autoSubscribe:, bufferActions:)
. I see that the underlying API sendidentifier
to the backend, but sincename
is a standalone parameter, I think it would make sense to abstract it a little bit more.The text was updated successfully, but these errors were encountered: