Review individual commits

[krobelus]

Instead of reviewing the sum of all changes, I'd like to review commits one-by-one.

Unfortunately, the github API doesn't make this easy.
I have a hacky script that tries to compute the line numbers that github expects but it fails when there are merge commits

[danobi]

Yeah, per commit reviewing would be nice. Although I believe even GH itself has restrictions on what kind of comments you can leave on per-commit reviews. IIRC you can't do spans (someone should double check me)

[danobi]

I am also thinking about this in the context of #47 (comment) . I believe we can build on top of PR metadata for this

[krobelus]

the hardest part is reverse engineering the github API.
An obvious workaround is to post the literal (per commit) prr-files as comments on github, I wonder how well that is received

[rmacklin]

the hardest part is reverse engineering the github API

It might be easier to look at prior art. As a reference, the octo.nvim plugin gained support for individual commit reviewing in this PR: pwntester/octo.nvim#294 after seeing it had been solved by https://github.com/ldelossa/gh.nvim

[danobi]

Thanks for the pointers!

[rmacklin]

You're welcome! Thank you for working on this project :) - I'm not yet using prr myself (mainly because I kinda rely on the ability to review individual commits) but it looks quite interesting/promising!