Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

response.setEncoding missing when using Browserify #161

Closed
shaneneuerburg opened this issue Feb 26, 2014 · 2 comments · Fixed by #162
Closed

response.setEncoding missing when using Browserify #161

shaneneuerburg opened this issue Feb 26, 2014 · 2 comments · Fixed by #162

Comments

@shaneneuerburg
Copy link
Contributor

First off, I understand that the initial target of the this module was for node, and not the browser. With that said, I am using this module with Browserify on the web.

When Restler handles the response in _responseHandler, response.setEncoding is called. For reasons unknown to me, that particular method is not defined when on the web. I don't know what side effects could be caused by not calling it either.

I will be creating a pull request shortly that checks to see if that method is defined before calling it to potentially resolve this issue.

@easternbloc
Copy link
Collaborator

Are you referring to this?

browserify/http-browserify#21

If so I think it should be addressed in browserify...

@MiguelCastillo
Copy link

@easternbloc http-browserify seems like that's the correct place to fix the issue... But it seems like we could get a very simple fix in restler to address this issue while we wait for the PR that does not seem to be going anywhere.

browserify/http-browserify#10

A simple fix would be much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants