Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom xml2js options not provided to parser when directly calling the request() method #257

Open
mbise1993 opened this issue Dec 3, 2017 · 1 comment

Comments

@mbise1993
Copy link

The parsers.xml.options object is only set in the shortcutOptions() method. However, when directly calling the request() method from client code, shortcutOptions() never gets called so the XML parser doesn't receive options set by the client. My fix for this was to change the first line in the request() method to:
var request = new Request(url, shortcutOptions(options, options.method));

If you'd like, I can submit a PR with this change.

@amitguptagwl
Copy link

This project seems inactive from last 2 years. But you can have a look on https://www.npmjs.com/package/restler-base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants