Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialect specific handling of case sensitivity #85

Open
machow opened this issue Apr 13, 2017 · 3 comments
Open

Dialect specific handling of case sensitivity #85

machow opened this issue Apr 13, 2017 · 3 comments

Comments

@machow
Copy link
Contributor

machow commented Apr 13, 2017

Currently, to workaround tsql issues...

  1. AST representations are converted to lowercase
  2. Column names are converted to lowercase

In postgres, these are not issues because unquoted column names should be made lowercase in the AST (as the official parser does). This also means that column names tend to be lowercase, too. Using casing is possible, though, so we don't want to convert everything to lowercase for postgres.

@filipsch
Copy link
Contributor

filipsch commented May 15, 2018

As a sidenote (without completely understanding the entire context and history), I noticed that AS and as for aliasing are treated differently in postgresql, while they shouldn't.

@machow
Copy link
Contributor Author

machow commented May 17, 2018

I'm not sure I understand, but in case it helps, it looks like table aliases aren't converted to an alias node (but are Unshaped). In this case the "AS" keyword is stored as written, which might be causing the casing issues?

image

@filipsch
Copy link
Contributor

@machow, yup, that must be it. Thanks for the pointer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants