Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data sampling can produce invalid JSON #6

Open
rflprr opened this issue Oct 9, 2017 · 1 comment
Open

Data sampling can produce invalid JSON #6

rflprr opened this issue Oct 9, 2017 · 1 comment
Assignees
Labels

Comments

@rflprr
Copy link
Contributor

rflprr commented Oct 9, 2017

For dataset:
https://data.world/rflprr/google-ds-connector-performance

And query:
SELECT * FROM hdx_org

It seems somewhere in return textLines.slice(0, sampleSize).map(JSON.parse); in rest.gs, one of the values has a starting quote but does not end the quote.

@rflprr rflprr added the bug label Oct 9, 2017
kndungu added a commit to kndungu/data-studio-connector that referenced this issue Oct 31, 2017
@rflprr
Copy link
Contributor Author

rflprr commented Apr 10, 2018

Google App's FetchUrl service limits response size to 25Mb.
Solving this issue would require:

  1. Google to extend that limit for data.world, or
  2. data.world to add support for HTTP range requests, so that the connector could retrieve results in 25Mb chunks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants