Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3: does not detect complete removal of a key #74

Open
yarikoptic opened this issue Apr 13, 2020 · 0 comments
Open

s3: does not detect complete removal of a key #74

yarikoptic opened this issue Apr 13, 2020 · 0 comments

Comments

@yarikoptic
Copy link
Member

Somewhat relates to #73 -- in that case it is content to the older versions which was removed, here I am talking about completely removed keys, so there is no even DeleteMarker.

If bucket is versioned, we assume that we would see DeleteMarker whenever file is gone. But if key is removed entirely, with all prior versions, there is no DeleteMarker.

Because IIRC we traverse bucket anyways -- we would either need to start doing what we do for regular crawler (not s3) and keep the full list of downloaded items, or traverse the worktree and delete files no longer on S3 side. It should probably be optional, since should be enabled with clear idea that there should be no longer...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant