diff --git a/DESCRIPTION b/DESCRIPTION index 9843402d..bafabe5e 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,7 +1,7 @@ Type: Package Package: flextable Title: Functions for Tabular Reporting -Version: 0.9.6.011 +Version: 0.9.6.012 Authors@R: c( person("David", "Gohel", , "david.gohel@ardata.fr", role = c("aut", "cre")), person("ArData", role = "cph"), diff --git a/NEWS.md b/NEWS.md index 00d78110..95cf2dc3 100644 --- a/NEWS.md +++ b/NEWS.md @@ -26,6 +26,8 @@ - The `path` argument now has a signature of `part = c("body", "header", "footer", "all")`, but because only a single value can be selected, it will pick `"body"` by default, as before. +- Deprecate `lollipop()` since it produces (ugly) results that can be replaced +by nice results with `gg_chunk()` or `grid_chunk()`. ## Issues diff --git a/R/chunk_images.R b/R/chunk_images.R index c93a4d00..587fdde6 100644 --- a/R/chunk_images.R +++ b/R/chunk_images.R @@ -266,6 +266,10 @@ linerange <- function(value, min = NULL, max = NULL, rangecol = "#CCCCCC", #' - [compose()] and [as_paragraph()], #' - [append_chunks()], #' - [prepend_chunks()]. +#' +#' It is now deprecated and will be soon defunct because we +#' think it produces ugly results. Use [gg_chunk()] to +#' replace it. #' @param value values containing the bar size #' @param min min bar size. Default min of value #' @param max max bar size. Default max of value @@ -308,6 +312,7 @@ lollipop <- function(value, min = NULL, max = NULL, rangecol = "#CCCCCC", height = .2, unit = "in", raster_width = 30, positivecol = "#00CC00", negativecol = "#CC0000", neutralcol = "#CCCCCC", neutralrange = c(0, 0), rectanglesize = 2) { + .Deprecated(msg = "lollipop function is deprecated as authors don't like the result, please open an issue if you are using it.") width <- convin(unit = unit, x = width) height <- convin(unit = unit, x = height) diff --git a/man/lollipop.Rd b/man/lollipop.Rd index c27f6d8a..12bc254a 100644 --- a/man/lollipop.Rd +++ b/man/lollipop.Rd @@ -57,6 +57,10 @@ flextable with functions: \item \code{\link[=append_chunks]{append_chunks()}}, \item \code{\link[=prepend_chunks]{prepend_chunks()}}. } + +It is now deprecated and will be soon defunct because we +think it produces ugly results. Use \code{\link[=gg_chunk]{gg_chunk()}} to +replace it. } \note{ This chunk option requires package officedown in a R Markdown